Skip to content

Add deployment workflow#532

Merged
chrisaddy merged 1 commit intomasterfrom
codex/configure-auto-deploys-on-master-merge-with-pulumi-uh5ovr
May 18, 2025
Merged

Add deployment workflow#532
chrisaddy merged 1 commit intomasterfrom
codex/configure-auto-deploys-on-master-merge-with-pulumi-uh5ovr

Conversation

@chrisaddy
Copy link
Copy Markdown
Collaborator

@chrisaddy chrisaddy commented May 18, 2025

Changes

  • add new GitHub Actions workflow to deploy infrastructure on master
  • update infrastructure deploy task to run non-interactively
  • add Pulumi access token env var for non-interactive auth

Comments

Summary by CodeRabbit

  • Chores
    • Added automated deployment workflow triggered on pushes to the master branch.
    • Deployment now proceeds without manual confirmation during Pulumi operations.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2025

Walkthrough

A new GitHub Actions workflow for deployment was introduced, triggered by pushes to the master branch. The workflow checks out code, installs Flox, and runs a Pulumi-based deployment command. Additionally, the Pulumi deployment command in the .mise.toml configuration was updated to include the --yes flag for non-interactive execution.

Changes

File(s) Change Summary
.github/workflows/deploy.yaml Added a GitHub Actions workflow for automated deployment on pushes to the master branch.
.mise.toml Updated the "infrastructure:up" task to add --yes to the Pulumi command for auto-confirmation.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub
    participant Runner
    participant Flox
    participant Pulumi

    GitHub->>Runner: Trigger workflow on push to master
    Runner->>Runner: Checkout repository code
    Runner->>Flox: Install Flox via install-flox-action
    Runner->>Flox: Activate Flox environment
    Runner->>Pulumi: Run "pulumi up --yes" via mise task
    Pulumi-->>Runner: Deploy infrastructure
Loading

Poem

A workflow hops in, fresh and new,
Deploys with a push—no prompts to review!
Flox and Pulumi, a magical pair,
With --yes they leap, no need to beware.
Now infra goes up with a whisk of delight,
The rabbit approves—deployments done right! 🐇🚀

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 18, 2025

Graphite Automations

"Assign author to pull request" took an action on this PR • (05/18/25)

1 assignee was added to this PR based on John Forstmeier's automation.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
.mise.toml (1)

79-80: Enable non-interactive Pulumi confirmation
Adding --yes to the pulumi up command ensures CI can proceed without manual prompts. However, it also bypasses any confirmation for potentially destructive operations. Consider integrating safeguards—such as pre-deployment validation scripts or leveraging protected environments in GitHub—to prevent unintended infrastructure changes in production.

.github/workflows/deploy.yaml (4)

1-6: Restrict deployment trigger to prevent unintended runs
This workflow is invoked on every push to master. For added safety, you could:

  • Add a workflow_dispatch trigger for manual deployments.
  • Limit automatic runs to version tags (e.g., tags: ['v*']).
  • Tie the job to a protected GitHub Environment requiring approvals.

10-10: Switch to Ubuntu runner for cost and speed
Unless there’s a specific need for macOS, using ubuntu-latest reduces start-up latency and runner costs.


12-15: Ensure complete repository checkout
By default, actions/checkout fetches limited history and skips submodules. If your deployment relies on full history, tags, or submodules, configure it as follows:

- uses: actions/checkout@v4
+ uses: actions/checkout@v4
+ with:
+   fetch-depth: 0
+   submodules: true

16-21: Add concurrency and environment protection
To prevent overlapping deployments and enforce approvals, configure a concurrency group and bind the job to a protected environment:

 jobs:
   deploy:
+    concurrency:
+      group: deploy-infrastructure
+      cancel-in-progress: true
+    environment: production

This will serialize runs and require reviewers before production deploys.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between bb65590 and 2090c55.

📒 Files selected for processing (2)
  • .github/workflows/deploy.yaml (1 hunks)
  • .mise.toml (1 hunks)
🔇 Additional comments (1)
.github/workflows/deploy.yaml (1)

18-19: Verify PULUMI_ACCESS_TOKEN secret configuration
Ensure the PULUMI_ACCESS_TOKEN secret is defined in your repository or organization settings and scoped with the minimum permissions required for the non-interactive Pulumi login.

Comment thread .mise.toml
@chrisaddy chrisaddy merged commit 29337ee into master May 18, 2025
5 checks passed
@chrisaddy chrisaddy deleted the codex/configure-auto-deploys-on-master-merge-with-pulumi-uh5ovr branch May 18, 2025 21:36
@coderabbitai coderabbitai Bot mentioned this pull request May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants